- warn on use of deprecated regexp configs (LOGSTASH-756)

lib/logstash/filters/csv.rb

@@ -61,6 +61,7 @@ def register
     #TODO(electrical): At some point this can be removed
     @config.each do |field, dest|
       next if (RESERVED + ["fields", "separator", "source", "columns", "target"]).member?(field)
+      @logger.warn("You used a deprecated setting '#{field} => #{dest}'. You should use 'source => "%{field}"' and 'target => %{dest}'")
       @csv[field] = dest
     end
 

lib/logstash/filters/date.rb

@@ -119,9 +119,9 @@ def register
     locale = parseLocale(@config["locale"][0]) if @config["locale"] != nil and @config["locale"][0] != nil
     missing = []
     @config.each do |field, value|
-      next if (RESERVED + ["locale"]).include?(field)
-      next if (RESERVED + ["match"]).include?(field)
+      next if (RESERVED + ["locale", "match"]).include?(field)
 
+      @logger.warn("You used a deprecated setting '#{field} => #{value}'. You should use 'match => [ \"#{field}\", \"#{value}\" ]'")
       # values here are an array of format strings for the given field.
       setupMatcher(field, locale, missing, value) # value.each
     end # @config.each

lib/logstash/filters/grok.rb

@@ -293,6 +293,7 @@ def register
       patterns.each do |pattern|
         @logger.debug? and @logger.debug("regexp: #{@type}/#{field}", :pattern => pattern)
         @patterns[field].compile(pattern)
+        @logger.warn("You used a deprecated setting '#{field} => #{pattern}'. You should use 'match => [ \"#{field}\", \"#{pattern}\" ]'")
       end
     end # @config.each
   end # def register

lib/logstash/filters/json.rb

@@ -24,7 +24,7 @@ class LogStash::Filters::Json < LogStash::Filters::Base
   # JSON in the value of the source field will be expanded into a
   # datastructure in the "dest" field.  Note: if the "dest" field
   # already exists, it will be overridden.
-  config /[A-Za-z0-9_@-]+/, :validate => :string
+  config /[A-Za-z0-9_@-]+/, :validate => :string, :deprecated => true
 
   # Config for json is:
   #
@@ -63,6 +63,7 @@ def register
 
     @config.each do |field, dest|
       next if (RESERVED + ["source", "target"]).member?(field)
+      @logger.warn("You used a deprecated setting '#{field} => #{dest}'. You should use 'source => "%{field}"' and 'target => %{dest}'")
       @json[field] = dest
     end
 

lib/logstash/filters/xml.rb

@@ -90,6 +90,7 @@ def register
     #TODO(electrical): Will be removed when its fully deprecated
     @config.each do |field, dest|
       next if (RESERVED + ["xpath", "store_xml", "source", "target"]).member?(field)
+      @logger.warn("You used a deprecated setting '#{field} => #{dest}'. You should use 'source => "%{field}"' and 'target => %{dest}'")
       @xml[field] = dest
     end