Skip to content

Commit

Permalink
[PATCH] fix extra BIOS invocation during resume
Browse files Browse the repository at this point in the history
It causes extra moon icons blinking on x60, and breaks at least two other
systems.

During resume, we do not know that "reboot"/"shutdown" method was used, so
we assume "plaform" and call BIOS, anyway...

This is 2.6.21 material, and should fix 2 or 3 regressions from 2.6.20.

Signed-off-by: Pavel Machek <[email protected]>
Acked-by: "Rafael J. Wysocki" <[email protected]>
Cc: Adrian Bunk <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
pavelmachek authored and Linus Torvalds committed Mar 23, 2007
1 parent 165b239 commit 058560f
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions kernel/power/disk.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,18 +241,11 @@ static int software_resume(void)
goto Done;
}

error = platform_prepare();
if (error) {
swsusp_free();
goto Thaw;
}

pr_debug("PM: Reading swsusp image.\n");

error = swsusp_read();
if (error) {
swsusp_free();
platform_finish();
goto Thaw;
}

Expand All @@ -270,7 +263,6 @@ static int software_resume(void)
enable_nonboot_cpus();
Free:
swsusp_free();
platform_finish();
device_resume();
resume_console();
Thaw:
Expand Down

0 comments on commit 058560f

Please sign in to comment.