Skip to content

Commit

Permalink
sound: oss: Use kernel_read_file_from_path() for mod_firmware_load()
Browse files Browse the repository at this point in the history
Since recently we have kernel_read_file_from_path(), and it's doing
the same thing as our own home-baked mod_firmware_load().  Let's use
the official API function and clean up the old code.

Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
tiwai committed Jul 26, 2016
1 parent 4a6baf1 commit 0984d15
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 79 deletions.
1 change: 0 additions & 1 deletion sound/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#

obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND_PRIME) += sound_firmware.o
obj-$(CONFIG_SOUND_PRIME) += oss/
obj-$(CONFIG_DMASOUND) += oss/
obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ sh/ synth/ usb/ \
Expand Down
29 changes: 28 additions & 1 deletion sound/oss/sound_firmware.h
Original file line number Diff line number Diff line change
@@ -1,2 +1,29 @@
extern int mod_firmware_load(const char *fn, char **fp);
#include <linux/fs.h>

/**
* mod_firmware_load - load sound driver firmware
* @fn: filename
* @fp: return for the buffer.
*
* Load the firmware for a sound module (up to 128K) into a buffer.
* The buffer is returned in *fp. It is allocated with vmalloc so is
* virtually linear and not DMAable. The caller should free it with
* vfree when finished.
*
* The length of the buffer is returned on a successful load, the
* value zero on a failure.
*
* Caution: This API is not recommended. Firmware should be loaded via
* request_firmware.
*/
static inline int mod_firmware_load(const char *fn, char **fp)
{
loff_t size;
int err;

err = kernel_read_file_from_path((char *)fn, (void **)fp, &size,
131072, READING_FIRMWARE);
if (err < 0)
return 0;
return size;
}
77 changes: 0 additions & 77 deletions sound/sound_firmware.c

This file was deleted.

0 comments on commit 0984d15

Please sign in to comment.