Skip to content

Commit

Permalink
[PATCH] revert fs/char_dev.c CONFIG_BASE_FULL change
Browse files Browse the repository at this point in the history
This reverts a fs/char_dev.c patch that was merged into BK on March 3.

The problem is that it breaks things ... __register_chrdev_region() has
a block of code, commented "temporary" for over two years now, which
fails rudely during PCMCIA initialization or other register_chrdev()
calls, because it doesn't "degrade to linked list".  This keeps whole
subsystems from working.

A real fix to that "temporary" code should be possible, using some better
scheme to allocate major numbers, but it's not something I want to spend
time on just now.

Signed-off-by: David Brownell <[email protected]>
Acked-by: Matt Mackall <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
David Brownell authored and Linus Torvalds committed Apr 17, 2005
1 parent a757e64 commit 1d4d5b3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/char_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@

static struct kobj_map *cdev_map;

/* degrade to linked list for small systems */
#define MAX_PROBE_HASH (CONFIG_BASE_SMALL ? 1 : 255)
#define MAX_PROBE_HASH 255 /* random */

static DECLARE_MUTEX(chrdevs_lock);

Expand Down

0 comments on commit 1d4d5b3

Please sign in to comment.