Skip to content

Commit

Permalink
stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
Browse files Browse the repository at this point in the history
Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):

init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?

Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).

Link: https://lore.kernel.org/lkml/[email protected]/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <[email protected]>
Cc: Xiu Jianfeng <[email protected]>
Signed-off-by: GONG, Ruiqi <[email protected]>
Reviewed-by: Christophe Leroy <[email protected]>
Fixes: 39218ff ("stack: Optionally randomize kernel stack offset each syscall")
Signed-off-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
GONG, Ruiqi authored and kees committed Jul 2, 2022
1 parent 6a022dd commit 375561b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
#include <linux/kcsan.h>
#include <linux/init_syscalls.h>
#include <linux/stackdepot.h>
#include <linux/randomize_kstack.h>
#include <net/net_namespace.h>

#include <asm/io.h>
Expand Down

0 comments on commit 375561b

Please sign in to comment.