filemap: Handle error return from __filemap_get_folio()

Smatch reports that filemap_fault() was missed in the conversion of __filemap_get_folio() error returns from NULL to ERR_PTR. Fixes: 66dabbb ("mm: return an ERR_PTR from __filemap_get_folio") Reported-by: Dan Carpenter <[email protected]> Reported-by: [email protected] Reported-by: Christoph Hellwig <[email protected]> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
niw · May 6, 2023 · 38a55db · 38a55db
1 parent dd9e11d
commit 38a55db
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/mm/filemap.c b/mm/filemap.c
@@ -3378,7 +3378,7 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
 	 * re-find the vma and come back and find our hopefully still populated
 	 * page.
 	 */
-	if (folio)
+	if (!IS_ERR(folio))
 		folio_put(folio);
 	if (mapping_locked)
 		filemap_invalidate_unlock_shared(mapping);