Skip to content

Commit

Permalink
crypto: geode-aes - convert to skcipher API and make thread-safe
Browse files Browse the repository at this point in the history
The geode AES driver is heavily broken because it stores per-request
state in the transform context.  So it will crash or produce the wrong
result if used by any of the many places in the kernel that issue
concurrent requests for the same transform object.

This driver is also implemented using the deprecated blkcipher API,
which makes it difficult to fix, and puts it among the drivers
preventing that API from being removed.

Convert this driver to use the skcipher API, and change it to not store
per-request state in the transform context.

Fixes: 9fe757b ("[PATCH] crypto: Add support for the Geode LX AES hardware")
Signed-off-by: Eric Biggers <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
ebiggers authored and herbertx committed Oct 23, 2019
1 parent e53619c commit 4549f7e
Show file tree
Hide file tree
Showing 2 changed files with 149 additions and 306 deletions.
Loading

0 comments on commit 4549f7e

Please sign in to comment.