Skip to content

Commit

Permalink
clockevents/drivers/exynos_mct: Remove unneeded container_of()
Browse files Browse the repository at this point in the history
Patch removes unneeded container_of() macro in exynos4_local_timer_setup().
Instead let's pass mevt pointer to setup and stop functions from
exynos4_mct_cpu_notify() and let them get evt pointer.

Tested on odroid-xu3.

Signed-off-by: Alexey Klimov <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
  • Loading branch information
trashsee authored and dlezcano committed Aug 10, 2015
1 parent 02760b1 commit 479a932
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/clocksource/exynos_mct.c
Original file line number Diff line number Diff line change
Expand Up @@ -442,13 +442,11 @@ static irqreturn_t exynos4_mct_tick_isr(int irq, void *dev_id)
return IRQ_HANDLED;
}

static int exynos4_local_timer_setup(struct clock_event_device *evt)
static int exynos4_local_timer_setup(struct mct_clock_event_device *mevt)
{
struct mct_clock_event_device *mevt;
struct clock_event_device *evt = &mevt->evt;
unsigned int cpu = smp_processor_id();

mevt = container_of(evt, struct mct_clock_event_device, evt);

mevt->base = EXYNOS4_MCT_L_BASE(cpu);
snprintf(mevt->name, sizeof(mevt->name), "mct_tick%d", cpu);

Expand Down Expand Up @@ -477,8 +475,10 @@ static int exynos4_local_timer_setup(struct clock_event_device *evt)
return 0;
}

static void exynos4_local_timer_stop(struct clock_event_device *evt)
static void exynos4_local_timer_stop(struct mct_clock_event_device *mevt)
{
struct clock_event_device *evt = &mevt->evt;

evt->set_mode(CLOCK_EVT_MODE_UNUSED, evt);
if (mct_int_type == MCT_INT_SPI) {
if (evt->irq != -1)
Expand All @@ -500,11 +500,11 @@ static int exynos4_mct_cpu_notify(struct notifier_block *self,
switch (action & ~CPU_TASKS_FROZEN) {
case CPU_STARTING:
mevt = this_cpu_ptr(&percpu_mct_tick);
exynos4_local_timer_setup(&mevt->evt);
exynos4_local_timer_setup(mevt);
break;
case CPU_DYING:
mevt = this_cpu_ptr(&percpu_mct_tick);
exynos4_local_timer_stop(&mevt->evt);
exynos4_local_timer_stop(mevt);
break;
}

Expand Down Expand Up @@ -570,7 +570,7 @@ static void __init exynos4_timer_resources(struct device_node *np, void __iomem
goto out_irq;

/* Immediately configure the timer on the boot CPU */
exynos4_local_timer_setup(&mevt->evt);
exynos4_local_timer_setup(mevt);
return;

out_irq:
Expand Down

0 comments on commit 479a932

Please sign in to comment.