Skip to content

Commit

Permalink
ALSA: aoa: Remove wrong i2c_set_clientdata in onyx_i2c_remove()
Browse files Browse the repository at this point in the history
It does not make sense to set clientdata to onyx in onyx_i2c_remove()
as we are going to kfree onyx.
What we really want here is i2c_set_clientdata(client, NULL);
Since the i2c core will take care of it now, so this patch just removes it.

Signed-off-by: Axel Lin <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
AxelLin authored and tiwai committed Dec 10, 2010
1 parent 9343009 commit 5144c53
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sound/aoa/codecs/onyx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,6 @@ static int onyx_i2c_remove(struct i2c_client *client)
of_node_put(onyx->codec.node);
if (onyx->codec_info)
kfree(onyx->codec_info);
i2c_set_clientdata(client, onyx);
kfree(onyx);
return 0;
}
Expand Down

0 comments on commit 5144c53

Please sign in to comment.