Skip to content

Commit

Permalink
drm/qxl: Call drm_helper_mode_fill_fb_struct() before drm_framebuffer…
Browse files Browse the repository at this point in the history
…_init()

We want framebuffers to be mostly useable already before
drm_framebuffer_init() is called, and so we will start demanding that
all the interesting format/size/etc. information be filled in before
drm_framebuffer_init(). drm_helper_mode_fill_fb_struct() will do that
for us, so let's make sure it gets called before drm_framebuffer_init().

Cc: Dave Airlie <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Daniel Vetter <[email protected]>
  • Loading branch information
vsyrjala committed Dec 15, 2016
1 parent a3f913c commit 5360943
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/qxl/qxl_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -624,12 +624,12 @@ qxl_framebuffer_init(struct drm_device *dev,
int ret;

qfb->obj = obj;
drm_helper_mode_fill_fb_struct(dev, &qfb->base, mode_cmd);
ret = drm_framebuffer_init(dev, &qfb->base, funcs);
if (ret) {
qfb->obj = NULL;
return ret;
}
drm_helper_mode_fill_fb_struct(dev, &qfb->base, mode_cmd);
return 0;
}

Expand Down

0 comments on commit 5360943

Please sign in to comment.