Skip to content

Commit

Permalink
bus: Explicitly include correct DT includes
Browse files Browse the repository at this point in the history
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <[email protected]>
Acked-by: Laurentiu Tudor <[email protected]>
Acked-by: Jernej Skrabec <[email protected]>
Link: https://lore.kernel.org/r/20230803-dt-header-cleanups-for-soc-v2-16-d8de2cc88bff@kernel.org
Signed-off-by: Arnd Bergmann <[email protected]>
  • Loading branch information
robherring authored and arndb committed Aug 12, 2023
1 parent 544885a commit 53c5ae6
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 6 deletions.
1 change: 1 addition & 0 deletions drivers/bus/fsl-mc/fsl-mc-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <linux/of_device.h>
#include <linux/of_address.h>
#include <linux/ioport.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/limits.h>
#include <linux/bitops.h>
Expand Down
2 changes: 0 additions & 2 deletions drivers/bus/fsl-mc/fsl-mc-msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
*
*/

#include <linux/of_device.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/bus/hisi_lpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#include <linux/logic_pio.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_platform.h>
#include <linux/pci.h>
#include <linux/platform_device.h>
#include <linux/serial_8250.h>
#include <linux/slab.h>

Expand Down
1 change: 0 additions & 1 deletion drivers/bus/omap_l3_smx.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <linux/io.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>

#include "omap_l3_smx.h"

Expand Down
2 changes: 2 additions & 0 deletions drivers/bus/simple-pm-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

#include <linux/clk.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/bus/sunxi-rsb.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/pm.h>
#include <linux/pm_runtime.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/bus/ti-pwmss.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <linux/io.h>
#include <linux/err.h>
#include <linux/pm_runtime.h>
#include <linux/of_device.h>
#include <linux/of_platform.h>

static const struct of_device_id pwmss_of_match[] = {
{ .compatible = "ti,am33xx-pwmss" },
Expand Down

0 comments on commit 53c5ae6

Please sign in to comment.