Skip to content

Commit

Permalink
netdev: Remove warning from __netif_schedule().
Browse files Browse the repository at this point in the history
It isn't helping anything and we aren't going to be able to change all
the drivers that do queue wakeups in strange situations.

Just letting a noop_qdisc get scheduled will work because when
qdisc_run() executes via net_tx_work() it will simply find no packets
pending when it makes the ->dequeue() call in qdisc_restart.

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed Jul 23, 2008
1 parent 8a6d2ea commit 5b3ab1d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1341,9 +1341,6 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)

void __netif_schedule(struct Qdisc *q)
{
if (WARN_ON_ONCE(q == &noop_qdisc))
return;

if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {
struct softnet_data *sd;
unsigned long flags;
Expand Down

0 comments on commit 5b3ab1d

Please sign in to comment.