cred: add missing return error code when set_cred_ucounts() failed

If set_cred_ucounts() failed, we need return the error code. Fixes: 905ae01 ("Add a reference to ucounts for each cred") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Yang Yingliang <[email protected]> Link: https://lkml.kernel.org/r/[email protected] Reviewed-by: Alexey Gladkov <[email protected]> Signed-off-by: Eric W. Biederman <[email protected]>
niw · May 28, 2021 · 5e6b8a5 · 5e6b8a5
1 parent f928ef6
commit 5e6b8a5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/kernel/cred.c b/kernel/cred.c
@@ -372,7 +372,8 @@ int copy_creds(struct task_struct *p, unsigned long clone_flags)
 		ret = create_user_ns(new);
 		if (ret < 0)
 			goto error_put;
-		if (set_cred_ucounts(new) < 0)
+		ret = set_cred_ucounts(new);
+		if (ret < 0)
 			goto error_put;
 	}