Skip to content

Commit

Permalink
drm/i915/fbc: Remove pointless "stride is multiple of 64 bytes" check
Browse files Browse the repository at this point in the history
Plane stride is always a multiple of 64 bytes. Remove the
pointless check that really doesn't have anything to do
with FBC.

Signed-off-by: Ville Syrjälä <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Vinod Govindapillai <[email protected]>
  • Loading branch information
vsyrjala committed Oct 5, 2023
1 parent 1fe5c43 commit 64909aa
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/gpu/drm/i915/display/intel_fbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -897,13 +897,6 @@ static bool icl_fbc_stride_is_valid(const struct intel_plane_state *plane_state)
static bool stride_is_valid(const struct intel_plane_state *plane_state)
{
struct drm_i915_private *i915 = to_i915(plane_state->uapi.plane->dev);
const struct drm_framebuffer *fb = plane_state->hw.fb;
unsigned int stride = intel_fbc_plane_stride(plane_state) *
fb->format->cpp[0];

/* This should have been caught earlier. */
if (drm_WARN_ON_ONCE(&i915->drm, (stride & (64 - 1)) != 0))
return false;

if (DISPLAY_VER(i915) >= 11)
return icl_fbc_stride_is_valid(plane_state);
Expand Down

0 comments on commit 64909aa

Please sign in to comment.