Skip to content

Commit

Permalink
mfd: tps68470: Drop unused MODULE_DEVICE_TABLE
Browse files Browse the repository at this point in the history
The Kconfig currently controlling compilation of this code is:

drivers/mfd/Kconfig:config MFD_TPS68470
drivers/mfd/Kconfig:    bool "TI TPS68470 Power Management / LED chips"

...meaning that it currently is not being built as a module by anyone.

Hence we remove the MODULE_DEVICE_TABLE since it is a no-op for
non-modular code.

There is no removal of <linux/module.h> here because there isn't one.
Instead, it is relying on including that implicitly from an ACPI header.

In cleaning up the ACPI instance of module.h (which also isn't strictly
needed), then this mfd driver breaks when MODULE_DEVICE_TABLE becomes
undefined here.

The easiest dependency solution is to simply defer the ACPI cleanup
until this change is present in mainline.

Signed-off-by: Paul Gortmaker <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
Paul Gortmaker authored and Lee Jones committed Feb 7, 2019
1 parent c0056bf commit 66265e7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/mfd/tps68470.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ static const struct acpi_device_id tps68470_acpi_ids[] = {
{"INT3472"},
{},
};
MODULE_DEVICE_TABLE(acpi, tps68470_acpi_ids);

static struct i2c_driver tps68470_driver = {
.driver = {
Expand Down

0 comments on commit 66265e7

Please sign in to comment.