Skip to content

Commit

Permalink
locking, latencytop: Annotate latency_lock as raw
Browse files Browse the repository at this point in the history
The latency_lock is lock can be taken in the guts of the
scheduler code and therefore cannot be preempted on -rt -
annotate it.

In mainline this change documents the low level nature of
the lock - otherwise there's no functional difference. Lockdep
and Sparse checking will work as usual.

Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
KAGA-KOKO authored and Ingo Molnar committed Sep 13, 2011
1 parent 2737c49 commit 757455d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions kernel/latencytop.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
#include <linux/list.h>
#include <linux/stacktrace.h>

static DEFINE_SPINLOCK(latency_lock);
static DEFINE_RAW_SPINLOCK(latency_lock);

#define MAXLR 128
static struct latency_record latency_record[MAXLR];
Expand All @@ -72,19 +72,19 @@ void clear_all_latency_tracing(struct task_struct *p)
if (!latencytop_enabled)
return;

spin_lock_irqsave(&latency_lock, flags);
raw_spin_lock_irqsave(&latency_lock, flags);
memset(&p->latency_record, 0, sizeof(p->latency_record));
p->latency_record_count = 0;
spin_unlock_irqrestore(&latency_lock, flags);
raw_spin_unlock_irqrestore(&latency_lock, flags);
}

static void clear_global_latency_tracing(void)
{
unsigned long flags;

spin_lock_irqsave(&latency_lock, flags);
raw_spin_lock_irqsave(&latency_lock, flags);
memset(&latency_record, 0, sizeof(latency_record));
spin_unlock_irqrestore(&latency_lock, flags);
raw_spin_unlock_irqrestore(&latency_lock, flags);
}

static void __sched
Expand Down Expand Up @@ -190,7 +190,7 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)
lat.max = usecs;
store_stacktrace(tsk, &lat);

spin_lock_irqsave(&latency_lock, flags);
raw_spin_lock_irqsave(&latency_lock, flags);

account_global_scheduler_latency(tsk, &lat);

Expand Down Expand Up @@ -231,7 +231,7 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)
memcpy(&tsk->latency_record[i], &lat, sizeof(struct latency_record));

out_unlock:
spin_unlock_irqrestore(&latency_lock, flags);
raw_spin_unlock_irqrestore(&latency_lock, flags);
}

static int lstats_show(struct seq_file *m, void *v)
Expand Down

0 comments on commit 757455d

Please sign in to comment.