Skip to content

Commit

Permalink
x86/pci/xen: Disable PCI/MSI[-X] masking for XEN_HVM guests
Browse files Browse the repository at this point in the history
When a XEN_HVM guest uses the XEN PIRQ/Eventchannel mechanism, then
PCI/MSI[-X] masking is solely controlled by the hypervisor, but contrary to
XEN_PV guests this does not disable PCI/MSI[-X] masking in the PCI/MSI
layer.

This can lead to a situation where the PCI/MSI layer masks an MSI[-X]
interrupt and the hypervisor grants the write despite the fact that it
already requested the interrupt. As a consequence interrupt delivery on the
affected device is not happening ever.

Set pci_msi_ignore_mask to prevent that like it's done for XEN_PV guests
already.

Fixes: 809f926 ("xen: map MSIs into pirqs")
Reported-by: Jeremi Piotrowski <[email protected]>
Reported-by: Dusty Mabe <[email protected]>
Reported-by: Salvatore Bonaccorso <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Noah Meyerhans <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/87tuaduxj5.ffs@tglx
  • Loading branch information
KAGA-KOKO committed Apr 29, 2022
1 parent 1fa568e commit 7e0815b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion arch/x86/pci/xen.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,6 @@ static __init void xen_setup_pci_msi(void)
else
xen_msi_ops.setup_msi_irqs = xen_setup_msi_irqs;
xen_msi_ops.teardown_msi_irqs = xen_pv_teardown_msi_irqs;
pci_msi_ignore_mask = 1;
} else if (xen_hvm_domain()) {
xen_msi_ops.setup_msi_irqs = xen_hvm_setup_msi_irqs;
xen_msi_ops.teardown_msi_irqs = xen_teardown_msi_irqs;
Expand All @@ -481,6 +480,11 @@ static __init void xen_setup_pci_msi(void)
* in allocating the native domain and never use it.
*/
x86_init.irqs.create_pci_msi_domain = xen_create_pci_msi_domain;
/*
* With XEN PIRQ/Eventchannels in use PCI/MSI[-X] masking is solely
* controlled by the hypervisor.
*/
pci_msi_ignore_mask = 1;
}

#else /* CONFIG_PCI_MSI */
Expand Down

0 comments on commit 7e0815b

Please sign in to comment.