Skip to content

Commit

Permalink
ALSA: ca0106: Use snd_ctl_rename() to rename a control
Browse files Browse the repository at this point in the history
With the recent addition of hashed controls lookup it's not enough to just
update the control name field, the hash entries for the modified control
have to be updated too.

snd_ctl_rename() takes care of that, so use it instead of directly
modifying the control name.

Fixes: c27e1ef ("ALSA: control: Use xarray for faster lookups")
Cc: [email protected]
Signed-off-by: Maciej S. Szmigiero <[email protected]>
Link: https://lore.kernel.org/r/bffee980a420f9b0eee5681d2f48d34a70cec0ce.1666296963.git.maciej.szmigiero@oracle.com
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
maciejsszmigiero authored and tiwai committed Oct 21, 2022
1 parent 36476b8 commit 957ccc4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/ca0106/ca0106_mixer.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ static int rename_ctl(struct snd_card *card, const char *src, const char *dst)
{
struct snd_kcontrol *kctl = ctl_find(card, src);
if (kctl) {
strcpy(kctl->id.name, dst);
snd_ctl_rename(card, kctl, dst);
return 0;
}
return -ENOENT;
Expand Down

0 comments on commit 957ccc4

Please sign in to comment.