Skip to content

Commit

Permalink
blk-mq: fixup "Convert to new hotplug state machine"
Browse files Browse the repository at this point in the history
The "blk_mq_queue_reinit_dead()" just cleared the cpumask instead doing
a copy. Since we might never had an online callback we could end up with
a ZERO mask which in turn leads to crash as test robot demonstarted.

Fixes: 65d5291 ("blk-mq: Convert to new hotplug state machine")
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Sebastian Andrzej Siewior authored and axboe committed Sep 23, 2016
1 parent 65d5291 commit 97a3286
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion block/blk-mq.c
Original file line number Diff line number Diff line change
Expand Up @@ -2158,7 +2158,7 @@ static void blk_mq_queue_reinit_work(void)

static int blk_mq_queue_reinit_dead(unsigned int cpu)
{
cpumask_clear_cpu(cpu, &cpuhp_online_new);
cpumask_copy(&cpuhp_online_new, cpu_online_mask);
blk_mq_queue_reinit_work();
return 0;
}
Expand Down

0 comments on commit 97a3286

Please sign in to comment.