Skip to content

Commit

Permalink
opp: Don't return opp_dev from _find_opp_dev()
Browse files Browse the repository at this point in the history
The caller of _find_opp_dev() only needs to know if the opp_dev is there
in the list or not.

Signed-off-by: Viresh Kumar <[email protected]>
  • Loading branch information
vireshk committed Nov 6, 2020
1 parent 27c0948 commit 9e62eda
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions drivers/opp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,31 +32,29 @@ DEFINE_MUTEX(opp_table_lock);
/* Flag indicating that opp_tables list is being updated at the moment */
static bool opp_tables_busy;

static struct opp_device *_find_opp_dev(const struct device *dev,
struct opp_table *opp_table)
static bool _find_opp_dev(const struct device *dev, struct opp_table *opp_table)
{
struct opp_device *opp_dev;
bool found = false;

mutex_lock(&opp_table->lock);
list_for_each_entry(opp_dev, &opp_table->dev_list, node)
if (opp_dev->dev == dev)
return opp_dev;
if (opp_dev->dev == dev) {
found = true;
break;
}

return NULL;
mutex_unlock(&opp_table->lock);
return found;
}

static struct opp_table *_find_opp_table_unlocked(struct device *dev)
{
struct opp_table *opp_table;
bool found;

list_for_each_entry(opp_table, &opp_tables, node) {
mutex_lock(&opp_table->lock);
found = !!_find_opp_dev(dev, opp_table);
mutex_unlock(&opp_table->lock);

if (found) {
if (_find_opp_dev(dev, opp_table)) {
_get_opp_table_kref(opp_table);

return opp_table;
}
}
Expand Down

0 comments on commit 9e62eda

Please sign in to comment.