Skip to content

Commit

Permalink
Merge git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6
Browse files Browse the repository at this point in the history
* git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6:
  pcmcia: disable pcmcia ioctl for !ARM, prepare for removal
  pcmcia: CodingStyle fixes
  pcmcia: alchemy: fixup wrong comments
  pcmcia: remove irq_list parameter from pd6729
  yenta_socket: ENE CB712 CardBus bridge needs special treatment with Echo Audio Indigo soundcards
  • Loading branch information
torvalds committed Mar 4, 2010
2 parents 03a2c4d + a3f916f commit a2e28fc
Show file tree
Hide file tree
Showing 9 changed files with 973 additions and 1,027 deletions.
12 changes: 9 additions & 3 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,25 @@ Who: Mauro Carvalho Chehab <[email protected]>
---------------------------

What: PCMCIA control ioctl (needed for pcmcia-cs [cardmgr, cardctl])
When: November 2005
When: 2.6.35/2.6.36
Files: drivers/pcmcia/: pcmcia_ioctl.c
Why: With the 16-bit PCMCIA subsystem now behaving (almost) like a
normal hotpluggable bus, and with it using the default kernel
infrastructure (hotplug, driver core, sysfs) keeping the PCMCIA
control ioctl needed by cardmgr and cardctl from pcmcia-cs is
unnecessary, and makes further cleanups and integration of the
unnecessary and potentially harmful (it does not provide for
proper locking), and makes further cleanups and integration of the
PCMCIA subsystem into the Linux kernel device driver model more
difficult. The features provided by cardmgr and cardctl are either
handled by the kernel itself now or are available in the new
pcmciautils package available at
http://kernel.org/pub/linux/utils/kernel/pcmcia/
Who: Dominik Brodowski <[email protected]>

For all architectures except ARM, the associated config symbol
has been removed from kernel 2.6.34; for ARM, it will be likely
be removed from kernel 2.6.35. The actual code will then likely
be removed from kernel 2.6.36.
Who: Dominik Brodowski <[email protected]>

---------------------------

Expand Down
14 changes: 10 additions & 4 deletions drivers/pcmcia/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,23 @@ config PCMCIA_LOAD_CIS

config PCMCIA_IOCTL
bool "PCMCIA control ioctl (obsolete)"
depends on PCMCIA
depends on PCMCIA && ARM && !SMP && !PREEMPT
default y
help
If you say Y here, the deprecated ioctl interface to the PCMCIA
subsystem will be built. It is needed by cardmgr and cardctl
(pcmcia-cs) to function properly.
subsystem will be built. It is needed by the deprecated pcmcia-cs
tools (cardmgr, cardctl) to function properly.

You should use the new pcmciautils package instead (see
<file:Documentation/Changes> for location and details).

If unsure, say Y.
This config option will most likely be removed from kernel 2.6.35,
the associated code from kernel 2.6.36.

As the PCMCIA ioctl is not locking safe, it depends on !SMP and
!PREEMPT.

If unsure, say N.

config CARDBUS
bool "32-bit CardBus support"
Expand Down
2 changes: 1 addition & 1 deletion drivers/pcmcia/cardbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ int __ref cb_alloc(struct pcmcia_socket *s)
unsigned int max, pass;

s->functions = pci_scan_slot(bus, PCI_DEVFN(0, 0));
pci_fixup_cardbus(bus);
pci_fixup_cardbus(bus);

max = bus->secondary;
for (pass = 0; pass < 2; pass++)
Expand Down
Loading

0 comments on commit a2e28fc

Please sign in to comment.