capabilities: invert logic for clarity

The way the logic was presented, it was awkward to read and verify. Invert the logic using DeMorgan's Law to be more easily able to read and understand. Signed-off-by: Richard Guy Briggs <[email protected]> Reviewed-by: Serge Hallyn <[email protected]> Acked-by: James Morris <[email protected]> Acked-by: Kees Cook <[email protected]> Okay-ished-by: Paul Moore <[email protected]> Signed-off-by: James Morris <[email protected]>
niw · Oct 20, 2017 · c0d1ade · c0d1ade
1 parent 02ebbaf
commit c0d1ade
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/security/commoncap.c b/security/commoncap.c
@@ -782,10 +782,10 @@ static inline bool nonroot_raised_pE(struct cred *cred, kuid_t root)
 	bool ret = false;
 
 	if (__cap_grew(effective, ambient, cred) &&
-	    (!__cap_full(effective, cred) ||
-	     !__is_eff(root, cred) ||
-	     !__is_real(root, cred) ||
-	     !root_privileged()))
+	    !(__cap_full(effective, cred) &&
+	      __is_eff(root, cred) &&
+	      __is_real(root, cred) &&
+	      root_privileged()))
 		ret = true;
 	return ret;
 }