Skip to content

Commit

Permalink
ipc/util: drop ipc_rcu_alloc()
Browse files Browse the repository at this point in the history
No callers remain for ipc_rcu_alloc().  Drop the function.

[[email protected]: Rediff because the memset was temporarily inside ipc_rcu_free()]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Manfred Spraul <[email protected]>
Cc: Kees Cook <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
kees authored and torvalds committed Jul 12, 2017
1 parent 52f9089 commit c3f6fb6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
21 changes: 0 additions & 21 deletions ipc/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,27 +394,6 @@ void ipc_rmid(struct ipc_ids *ids, struct kern_ipc_perm *ipcp)
ipcp->deleted = true;
}

/**
* ipc_rcu_alloc - allocate ipc space
* @size: size desired
*
* Allocate memory for an ipc object.
* The first member must be struct kern_ipc_perm.
*/
struct kern_ipc_perm *ipc_rcu_alloc(int size)
{
/*
* We prepend the allocation with the rcu struct
*/
struct kern_ipc_perm *out = kvmalloc(size, GFP_KERNEL);
if (unlikely(!out))
return NULL;

memset(out, 0, size);
atomic_set(&out->refcount, 1);
return out;
}

int ipc_rcu_getref(struct kern_ipc_perm *ptr)
{
return atomic_inc_not_zero(&ptr->refcount);
Expand Down
3 changes: 0 additions & 3 deletions ipc/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,7 @@ int ipcperms(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp, short flg);
* Objects are reference counted, they start with reference count 1.
* getref increases the refcount, the putref call that reduces the recount
* to 0 schedules the rcu destruction. Caller must guarantee locking.
*
* struct kern_ipc_perm must be the first member in the allocated structure.
*/
struct kern_ipc_perm *ipc_rcu_alloc(int size);
int ipc_rcu_getref(struct kern_ipc_perm *ptr);
void ipc_rcu_putref(struct kern_ipc_perm *ptr,
void (*func)(struct rcu_head *head));
Expand Down

0 comments on commit c3f6fb6

Please sign in to comment.