affs: kstrdup() memory handling

There is a possibility of kstrdup() failure upon memory pressure. Therefore, returning ENOMEM even for new_opts. [[email protected]: cleanup] Signed-off-by: Sanidhya Kashyap <[email protected]> Cc: Taesoo kim <[email protected]> Cc: Fabian Frederick <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
niw · Apr 17, 2015 · c8f33d0 · c8f33d0
1 parent 79bda4d
commit c8f33d0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/fs/affs/super.c b/fs/affs/super.c
@@ -521,10 +521,14 @@ affs_remount(struct super_block *sb, int *flags, char *data)
 	int			 root_block;
 	unsigned long		 mount_flags;
 	int			 res = 0;
-	char			*new_opts = kstrdup(data, GFP_KERNEL);
+	char			*new_opts;
 	char			 volume[32];
 	char			*prefix = NULL;
 
+	new_opts = kstrdup(data, GFP_KERNEL);
+	if (!new_opts)
+		return -ENOMEM;
+
 	pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data);
 
 	sync_filesystem(sb);