Skip to content

Commit

Permalink
minixfs: switch to d_make_root()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Mar 21, 2012
1 parent 68acb8e commit ca85c07
Showing 1 changed file with 12 additions and 16 deletions.
28 changes: 12 additions & 16 deletions fs/minix/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -254,14 +254,6 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)
minix_set_bit(0,sbi->s_imap[0]->b_data);
minix_set_bit(0,sbi->s_zmap[0]->b_data);

/* set up enough so that it can read an inode */
s->s_op = &minix_sops;
root_inode = minix_iget(s, MINIX_ROOT_INO);
if (IS_ERR(root_inode)) {
ret = PTR_ERR(root_inode);
goto out_no_root;
}

/* Apparently minix can create filesystems that allocate more blocks for
* the bitmaps than needed. We simply ignore that, but verify it didn't
* create one with not enough blocks and bail out if so.
Expand All @@ -270,7 +262,7 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)
if (sbi->s_imap_blocks < block) {
printk("MINIX-fs: file system does not have enough "
"imap blocks allocated. Refusing to mount\n");
goto out_iput;
goto out_no_bitmap;
}

block = minix_blocks_needed(
Expand All @@ -279,13 +271,21 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)
if (sbi->s_zmap_blocks < block) {
printk("MINIX-fs: file system does not have enough "
"zmap blocks allocated. Refusing to mount.\n");
goto out_iput;
goto out_no_bitmap;
}

/* set up enough so that it can read an inode */
s->s_op = &minix_sops;
root_inode = minix_iget(s, MINIX_ROOT_INO);
if (IS_ERR(root_inode)) {
ret = PTR_ERR(root_inode);
goto out_no_root;
}

ret = -ENOMEM;
s->s_root = d_alloc_root(root_inode);
s->s_root = d_make_root(root_inode);
if (!s->s_root)
goto out_iput;
goto out_no_root;

if (!(s->s_flags & MS_RDONLY)) {
if (sbi->s_version != MINIX_V3) /* s_state is now out from V3 sb */
Expand All @@ -301,10 +301,6 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)

return 0;

out_iput:
iput(root_inode);
goto out_freemap;

out_no_root:
if (!silent)
printk("MINIX-fs: get root inode failed\n");
Expand Down

0 comments on commit ca85c07

Please sign in to comment.