Skip to content

Commit

Permalink
kconfig: qconf: remove unused argument from ConfigList::updateList()
Browse files Browse the repository at this point in the history
This function allocates 'item' before using it, so the argument 'item'
is always shadowed.

Remove the meaningless argument.

Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
masahir0y committed Aug 14, 2020
1 parent 9264115 commit cb77043
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions scripts/kconfig/qconf.cc
Original file line number Diff line number Diff line change
@@ -404,15 +404,15 @@ void ConfigList::updateSelection(void)
emit menuSelected(menu);
}

void ConfigList::updateList(ConfigItem* item)
void ConfigList::updateList()
{
ConfigItem* last = 0;
ConfigItem *item;

if (!rootEntry) {
if (mode != listMode)
goto update;
QTreeWidgetItemIterator it(this);
ConfigItem* item;

while (*it) {
item = (ConfigItem*)(*it);
@@ -990,7 +990,7 @@ void ConfigView::updateList(ConfigItem* item)
ConfigView* v;

for (v = viewList; v; v = v->nextView)
v->list->updateList(item);
v->list->updateList();
}

void ConfigView::updateListAll(void)
4 changes: 2 additions & 2 deletions scripts/kconfig/qconf.h
Original file line number Diff line number Diff line change
@@ -69,7 +69,7 @@ class ConfigList : public QTreeWidget {
public slots:
void setRootMenu(struct menu *menu);

void updateList(ConfigItem *item);
void updateList();
void setValue(ConfigItem* item, tristate val);
void changeValue(ConfigItem* item);
void updateSelection(void);
@@ -85,7 +85,7 @@ public slots:
void updateListAll(void)
{
updateAll = true;
updateList(NULL);
updateList();
updateAll = false;
}
void addColumn(colIdx idx)

0 comments on commit cb77043

Please sign in to comment.