Skip to content

Commit

Permalink
NFS: Fix a double page unlock
Browse files Browse the repository at this point in the history
Since commit 0bcbf03, nfs_readpage_release() has been used to
unlock the page in the read code.

Fixes: 0bcbf03 ("nfs: handle request add failure properly")
Cc: [email protected] # v4.5+
Signed-off-by: Trond Myklebust <[email protected]>
Signed-off-by: Anna Schumaker <[email protected]>
  • Loading branch information
trondmypd authored and amschuma-ntap committed Jun 24, 2016
1 parent 5e3a988 commit cbebaf8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/nfs/read.c
Original file line number Diff line number Diff line change
Expand Up @@ -367,13 +367,13 @@ readpage_async_filler(void *data, struct page *page)
nfs_list_remove_request(new);
nfs_readpage_release(new);
error = desc->pgio->pg_error;
goto out_unlock;
goto out;
}
return 0;
out_error:
error = PTR_ERR(new);
out_unlock:
unlock_page(page);
out:
return error;
}

Expand Down

0 comments on commit cbebaf8

Please sign in to comment.