Skip to content

Commit

Permalink
powerpc/ps3: use dma_mapping_error()
Browse files Browse the repository at this point in the history
The DMA address returned by dma_map_single() should be checked with
dma_mapping_error(). Fix the ps3stor_setup() function accordingly.

Fixes: 8007180 ("[POWERPC] PS3: Storage Driver Core")
Signed-off-by: Vincent Stehlé <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
vstehle authored and mpe committed Dec 15, 2020
1 parent 328e7e4 commit d0edaa2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ps3/ps3stor_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ int ps3stor_setup(struct ps3_storage_device *dev, irq_handler_t handler)
dev->bounce_lpar = ps3_mm_phys_to_lpar(__pa(dev->bounce_buf));
dev->bounce_dma = dma_map_single(&dev->sbd.core, dev->bounce_buf,
dev->bounce_size, DMA_BIDIRECTIONAL);
if (!dev->bounce_dma) {
if (dma_mapping_error(&dev->sbd.core, dev->bounce_dma)) {
dev_err(&dev->sbd.core, "%s:%u: map DMA region failed\n",
__func__, __LINE__);
error = -ENODEV;
Expand Down

0 comments on commit d0edaa2

Please sign in to comment.