Skip to content

Commit

Permalink
ALSA: oxfw: rename a structure so that it means backward compatibilit…
Browse files Browse the repository at this point in the history
…y to old drivers

In former commits, some model-specific members are split from the
structure. The structure is just to keep names for compatibility to old
drivers.

This commit arranges name of the structure and localize it.

Signed-off-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
takaswie authored and tiwai committed Dec 22, 2015
1 parent 3e2f457 commit d6ce6bb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 10 additions & 4 deletions sound/firewire/oxfw/oxfw.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ MODULE_AUTHOR("Clemens Ladisch <[email protected]>");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("snd-firewire-speakers");

struct compat_info {
const char *driver_name;
const char *vendor_name;
const char *model_name;
};

static bool detect_loud_models(struct fw_unit *unit)
{
const char *const models[] = {
Expand Down Expand Up @@ -59,7 +65,7 @@ static bool detect_loud_models(struct fw_unit *unit)
static int name_card(struct snd_oxfw *oxfw)
{
struct fw_device *fw_dev = fw_parent_device(oxfw->unit);
const struct device_info *info;
const struct compat_info *info;
char vendor[24];
char model[32];
const char *d, *v, *m;
Expand Down Expand Up @@ -87,7 +93,7 @@ static int name_card(struct snd_oxfw *oxfw)
/* to apply card definitions */
if (oxfw->entry->vendor_id == VENDOR_GRIFFIN ||
oxfw->entry->vendor_id == VENDOR_LACIE) {
info = (const struct device_info *)oxfw->entry->driver_data;
info = (const struct compat_info *)oxfw->entry->driver_data;
d = info->driver_name;
v = info->vendor_name;
m = info->model_name;
Expand Down Expand Up @@ -279,13 +285,13 @@ static void oxfw_remove(struct fw_unit *unit)
snd_card_free_when_closed(oxfw->card);
}

static const struct device_info griffin_firewave = {
static const struct compat_info griffin_firewave = {
.driver_name = "FireWave",
.vendor_name = "Griffin",
.model_name = "FireWave",
};

static const struct device_info lacie_speakers = {
static const struct compat_info lacie_speakers = {
.driver_name = "FWSpeakers",
.vendor_name = "LaCie",
.model_name = "FireWire Speakers",
Expand Down
6 changes: 0 additions & 6 deletions sound/firewire/oxfw/oxfw.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@
#include "../amdtp-am824.h"
#include "../cmp.h"

struct device_info {
const char *driver_name;
const char *vendor_name;
const char *model_name;
};

/* This is an arbitrary number for convinience. */
#define SND_OXFW_STREAM_FORMAT_ENTRIES 10
struct snd_oxfw {
Expand Down

0 comments on commit d6ce6bb

Please sign in to comment.