Skip to content

Commit

Permalink
udf: stop using s_dirt
Browse files Browse the repository at this point in the history
The UDF file-system does not need the 's_dirt' superblock flag because it does
not define the 'write_super()' method. This flag was set to 1 in few places and
set to 0 in '->sync_fs()' and was basically useless. Stop using it because it
is on its way out.

Signed-off-by: Artem Bityutskiy <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
  • Loading branch information
dedekind authored and jankara committed Jul 9, 2012
1 parent f007dbf commit db8109e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions fs/udf/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1974,7 +1974,6 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
sb->s_op = &udf_sb_ops;
sb->s_export_op = &udf_export_ops;

sb->s_dirt = 0;
sb->s_magic = UDF_SUPER_MAGIC;
sb->s_time_gran = 1000;

Expand Down Expand Up @@ -2096,10 +2095,6 @@ void _udf_err(struct super_block *sb, const char *function,
struct va_format vaf;
va_list args;

/* mark sb error */
if (!(sb->s_flags & MS_RDONLY))
sb->s_dirt = 1;

va_start(args, fmt);

vaf.fmt = fmt;
Expand Down Expand Up @@ -2161,7 +2156,6 @@ static int udf_sync_fs(struct super_block *sb, int wait)
* the buffer for IO
*/
mark_buffer_dirty(sbi->s_lvid_bh);
sb->s_dirt = 0;
sbi->s_lvid_dirty = 0;
}
mutex_unlock(&sbi->s_alloc_mutex);
Expand Down
1 change: 0 additions & 1 deletion fs/udf/udfdecl.h
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ static inline void udf_updated_lvid(struct super_block *sb)
WARN_ON_ONCE(((struct logicalVolIntegrityDesc *)
bh->b_data)->integrityType !=
cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN));
sb->s_dirt = 1;
UDF_SB(sb)->s_lvid_dirty = 1;
}
extern u64 lvid_get_unique_id(struct super_block *sb);
Expand Down

0 comments on commit db8109e

Please sign in to comment.