Skip to content

Commit

Permalink
ALSA: oxfw: add stream format quirk for SCS.1 models
Browse files Browse the repository at this point in the history
As long as I investigate SCS.1m, this model reports to transfer/receive
PCM data channels/MIDI conformant data channels in tx/rx AMDTP packet.
There's a contradiction that this model actually has no analog/digital
capture port for PCM frames and no physical MIDI ports.

I guess that SCS.1d also has the contradiction. This model has no
analog/digital ports for PCM frames and no physical MIDI ports, thus it
requires no streaming functionality.

This commit adds some modification codes to handle the contradiction,
as much as possible. Unfortunately, this module adds one PCM playback
substream for SCS.1d so as SCS.1m.

Signed-off-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
takaswie authored and tiwai committed Dec 22, 2015
1 parent 9e2004f commit de5126c
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion sound/firewire/oxfw/oxfw.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,16 @@ static int detect_quirks(struct snd_oxfw *oxfw)
* Stanton models supports asynchronous transactions for unique MIDI
* messages.
*/
if (oxfw->entry->vendor_id == OUI_STANTON)
if (oxfw->entry->vendor_id == OUI_STANTON) {
/* No physical MIDI ports. */
oxfw->midi_input_ports = 0;
oxfw->midi_output_ports = 0;

/* Output stream exists but no data channels are useful. */
oxfw->has_output = false;

return snd_oxfw_scs1x_add(oxfw);
}

/*
* TASCAM FireOne has physical control and requires a pair of additional
Expand Down

0 comments on commit de5126c

Please sign in to comment.