Skip to content

Commit

Permalink
printk: Declare log_wait properly
Browse files Browse the repository at this point in the history
kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. Should it be static?

Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: John Ogness <[email protected]>
Reviewed-by: Sergey Senozhatsky <[email protected]>
Reviewed-by: Petr Mladek <[email protected]>
Reviewed-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Petr Mladek <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
KAGA-KOKO authored and pmladek committed Sep 29, 2022
1 parent c60ba2d commit e3f12f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/proc/kmsg.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
#include <linux/uaccess.h>
#include <asm/io.h>

extern wait_queue_head_t log_wait;

static int kmsg_open(struct inode * inode, struct file * file)
{
return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC);
Expand Down
3 changes: 3 additions & 0 deletions include/linux/syslog.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#ifndef _LINUX_SYSLOG_H
#define _LINUX_SYSLOG_H

#include <linux/wait.h>

/* Close the log. Currently a NOP. */
#define SYSLOG_ACTION_CLOSE 0
/* Open the log. Currently a NOP. */
Expand Down Expand Up @@ -35,5 +37,6 @@
#define SYSLOG_FROM_PROC 1

int do_syslog(int type, char __user *buf, int count, int source);
extern wait_queue_head_t log_wait;

#endif /* _LINUX_SYSLOG_H */

0 comments on commit e3f12f0

Please sign in to comment.