ext2: check err when partial != NULL

Check err when partial == NULL is meaningless because partial == NULL means getting branch successfully without error. CC: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Chengguang Xu <[email protected]> Signed-off-by: Jan Kara <[email protected]>
niw · Nov 5, 2019 · e705f4b · e705f4b
1 parent df4bb5d
commit e705f4b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
@@ -701,10 +701,13 @@ static int ext2_get_blocks(struct inode *inode,
 		if (!partial) {
 			count++;
 			mutex_unlock(&ei->truncate_mutex);
-			if (err)
-				goto cleanup;
 			goto got_it;
 		}
+
+		if (err) {
+			mutex_unlock(&ei->truncate_mutex);
+			goto cleanup;
+		}
 	}
 
 	/*