Skip to content

Commit

Permalink
Revert "[SPARK-42508][CONNECT][ML] Extract the common .ml classes to …
Browse files Browse the repository at this point in the history
…`mllib-common`"

### What changes were proposed in this pull request?
Revert "[SPARK-42508][CONNECT][ML] Extract the common .ml classes to `mllib-common`"

but still keep Connect Server depends on `mllib` for [SPARK-42800](https://issues.apache.org/jira/browse/SPARK-42800)

### Why are the changes needed?
the [previous change](apache@5a5f04c) was too invasive, I want to be more careful and rethink before we go ahead for Spark Connect.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
existing UT

Closes apache#40517 from zhengruifeng/revert_mllib_common.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
  • Loading branch information
zhengruifeng committed Mar 22, 2023
1 parent 34c624e commit d679dab
Show file tree
Hide file tree
Showing 761 changed files with 232 additions and 1,407 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
catalyst, hive-thriftserver
- >-
streaming, sql-kafka-0-10, streaming-kafka-0-10,
mllib-local, mllib-common, mllib,
mllib-local, mllib,
yarn, mesos, kubernetes, hadoop-cloud, spark-ganglia-lgpl,
connect, protobuf
# Here, we split Hive and SQL tests into some of slow ones and the rest of them.
Expand Down
12 changes: 0 additions & 12 deletions connector/connect/client/jvm/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-mllib-common_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit d679dab

Please sign in to comment.