[Impeller] Don't do texture passthrough when opacity needs to be appl…

…ied (flutter#36337)
nkoneko · Sep 22, 2022 · ac6cb9f · ac6cb9f
1 parent fd15b06
commit ac6cb9f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/impeller/entity/contents/texture_contents.cc b/impeller/entity/contents/texture_contents.cc
@@ -11,6 +11,7 @@
 #include "impeller/entity/entity.h"
 #include "impeller/entity/texture_fill.frag.h"
 #include "impeller/entity/texture_fill.vert.h"
+#include "impeller/geometry/constants.h"
 #include "impeller/geometry/path_builder.h"
 #include "impeller/renderer/formats.h"
 #include "impeller/renderer/render_pass.h"
@@ -72,7 +73,8 @@ std::optional<Snapshot> TextureContents::RenderToSnapshot(
 
   // Passthrough textures that have simple rectangle paths and complete source
   // rects.
-  if (is_rect_ && source_rect_ == Rect::MakeSize(texture_->GetSize())) {
+  if (is_rect_ && source_rect_ == Rect::MakeSize(texture_->GetSize()) &&
+      opacity_ >= 1 - kEhCloseEnough) {
     auto scale = Vector2(bounds->size / Size(texture_->GetSize()));
     return Snapshot{.texture = texture_,
                     .transform = entity.GetTransformation() *