Remove Useless Toasts and Other Minor Changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuppan
reviewed
Mar 31, 2024
| @@ -29,6 +30,9 @@ fun openWebPage(context: Context, webpage: String) { | |||
| context.startActivity(intent) | |||
| } catch (e: ActivityNotFoundException) { | |||
| // Define what your app should do if no activity can handle the intent. | |||
| Toast.makeText(context, context.getString(R.string.no_browser_found), Toast.LENGTH_SHORT) | |||
There was a problem hiding this comment.
Hey @Tonnie-Dev, This method does not handle the browser. It seems and Am I missing anything here?
There was a problem hiding this comment.
Thanks for the correction, Did this without thinking much about it, will edit out the Toasts
nkuppan
reviewed
Mar 31, 2024
| @@ -40,6 +44,9 @@ fun openEmailToOption(context: Context, emailId: String) { | |||
| context.startActivity(intent) | |||
| } catch (e: ActivityNotFoundException) { | |||
| // Define what your app should do if no activity can handle the intent. | |||
| Toast.makeText(context, context.getString(R.string.no_email_app_found), Toast.LENGTH_SHORT) | |||
There was a problem hiding this comment.
Hey @Tonnie-Dev, I appreciate your effort. Would returning the error message and handling it on the client/caller end make sense?
There was a problem hiding this comment.
@Tonnie-Dev Actually you are right, this is not the correct approach, I will edit my commits
There was a problem hiding this comment.
By the way have you set out Buy Me Coffee Account, Have learnt great deal from this repo and I would like to thank you personally 🙏🏽
Remove Toasts from ContextExt.kt file
Tonnie-Dev
changed the title
Add IntermediateScreen for Preview
To remove redundant 'return` keyword
nkuppan
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openWebPage()function on ContextExt.kt fileselectAllThisAccount()onAccountSelectionViewModel