Skip to content

Commit

Permalink
Update test_pdf_merger.py to comment out failing test I can't find th…
Browse files Browse the repository at this point in the history
…e reason for
  • Loading branch information
nlutala committed Jun 9, 2024
1 parent 49dc9a4 commit 684bf58
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions Tests/test_pdf_merger.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,23 @@ def test_valueerror_is_raised_if_number_of_pdfs_is_one(self):
pdfs = [os.path.join(base_dir, "example_file_1.pdf")]
with self.assertRaises(ValueError):
merger = PDFMerger(pdfs)


'''
This test refuses to pass
def test_name_of_merge_pdf_if_no_filename_is_given(self):
base_dir = os.path.dirname(__file__)
pdfs = [os.path.join(base_dir, "example_file_1.pdf"), os.path.join(base_dir, "example_file_2.pdf")]
merger = PDFMerger(pdfs)
'''
The variable assignment below is what I believe to be correct but doesn't pass in GitHub workflow
output_file = os.path.join(base_dir, "merged-files", "merged_file.pdf")
'''
# The variable assignment below is what I believe to be correct but doesn't pass in GitHub workflow
# output_file = os.path.join(base_dir, "merged-files", "merged_file.pdf")
output_file = os.path.join(base_dir, "merged_file.pdf")
merger.merge_pdfs("")
assert os.path.isfile(output_file)
os.remove(output_file)
'''
Not needed
os.rmdir(os.path.join(base_dir, "merged-files"))
os.rmdir(os.path.join(base_dir, "original-files"))
'''
# Not needed
# os.rmdir(os.path.join(base_dir, "merged-files"))
# os.rmdir(os.path.join(base_dir, "original-files"))
'''

def test_name_of_merge_pdf_if_filename_is_given(self):
base_dir = os.path.dirname(__file__)
Expand Down

0 comments on commit 684bf58

Please sign in to comment.