Skip to content

Commit

Permalink
runtime: fix missing newline when dumping bad symbol table
Browse files Browse the repository at this point in the history
If the symbol table isn't sorted, we print it and abort.  However, we
were missing the line break after each symbol, resulting in one
gigantic line instead of a nicely formatted table.

Change-Id: Ie5c6f3c256d0e648277cb3db4496512a79d266dd
Reviewed-on: https://go-review.googlesource.com/1182
Reviewed-by: Russ Cox <[email protected]>
  • Loading branch information
aclements committed Dec 8, 2014
1 parent 0f2db82 commit 006ceb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/runtime/symtab.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func symtabinit() {
}
println("function symbol table not sorted by program counter:", hex(ftab[i].entry), gofuncname(f1), ">", hex(ftab[i+1].entry), f2name)
for j := 0; j <= i; j++ {
print("\t", hex(ftab[j].entry), " ", gofuncname((*_func)(unsafe.Pointer(&pclntable[ftab[j].funcoff]))))
print("\t", hex(ftab[j].entry), " ", gofuncname((*_func)(unsafe.Pointer(&pclntable[ftab[j].funcoff]))), "\n")
}
gothrow("invalid runtime symbol table")
}
Expand Down

0 comments on commit 006ceb2

Please sign in to comment.