Skip to content

Commit

Permalink
codereview: fix hg sync closing of CLs for subrepositories
Browse files Browse the repository at this point in the history
The regexp for closing CLs that were sent by you but committed by
someone else only matched messages for the main repository,
because of the added &repo=... for subrepositories.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14512045
  • Loading branch information
dominikh authored and robpike committed Oct 10, 2013
1 parent 950c284 commit 50d4dae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/codereview/codereview.py
Original file line number Diff line number Diff line change
Expand Up @@ -2402,7 +2402,7 @@ def IsRietveldSubmitted(ui, clname, hex):
return False
for msg in dict.get("messages", []):
text = msg.get("text", "")
m = re.match('\*\*\* Submitted as [^*]*?([0-9a-f]+) \*\*\*', text)
m = re.match('\*\*\* Submitted as [^*]*?r=([0-9a-f]+)[^ ]* \*\*\*', text)
if m is not None and len(m.group(1)) >= 8 and hex.startswith(m.group(1)):
return True
return False
Expand Down

0 comments on commit 50d4dae

Please sign in to comment.