Skip to content

Commit

Permalink
misc/cgo/test: make issue5548 test pickier
Browse files Browse the repository at this point in the history
If there is doubt about passing arguments correctly
(as there is in this test), there should be doubt about
getting the results back intact too. Using 0 and 1
(especially 0 for success) makes it easy to get a PASS
accidentally when the return value is not actually
being propagated. Use less common values.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://golang.org/cl/141110043
  • Loading branch information
rsc committed Sep 5, 2014
1 parent 4b3906f commit fcbe51c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions misc/cgo/test/issue5548.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ import "C"
//export issue5548FromC
func issue5548FromC(s string, i int) int {
if len(s) == 4 && s == "test" && i == 42 {
return 1
return 12345
}
return 0
println("got", len(s), i)
return 9876
}

func test5548(t *testing.T) {
if C.issue5548_in_c() == 0 {
t.Fail()
if x := C.issue5548_in_c(); x != 12345 {
t.Errorf("issue5548_in_c = %d, want %d", x, 12345)
}
}

0 comments on commit fcbe51c

Please sign in to comment.