Feat/transient #273
Open
Feat/transient #273
+804
−354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following utility functions to support the move
- `org-transclusion-extension-functions-add-or-remove`
- `org-transclusion-extension-set-a-hook-functions`
Modified function `org-transclusion-load-extensions-maybe` so that setting
`org-transclusion-extensions` with the `customize` facilities will automatically
activate the corresponding minor mode for each extension.
Use of `customize` and `org-transclusion-extensions` is optional. Users can
ignore these and use extensions by loading and activating minor modes in their
init.el file.
So, this below should work (each minor mode function has the autoload cookie, so
the library should not have to be explicitly loaded).
```
(with-eval-after-load 'org-transclusion
(org-transclusion-indent-mode +1))
```
Adding to the list and requiring the library like this below did not use to be
necessary...
```
(with-eval-after-load 'org-transclusion
(add-to-list 'org-transclusion-extensions 'org-transclusion-indent-mode)
(require 'org-transclusion-indent-mode))
```
The Customizing facility would load the active extension library with
`require`.... But I think this was never intuitive.
'((cons e1 e2)) is incorrect. `cons` will be part of the list.
While fixing the issue, I am extending the "add" operation to allow for *any* link. A lot is still under development and many things will change. But this seems to work without breaking any user-facing commands and function. Introduced a new function `org-transclusion-add-target-marker`, which helps transcluding *any* link (as long as Org can reach the link target and Emacs creates the link's target buffer -- tested with `notmuch` link successfully). Refactored the code for the "add" operation with this new approach.
The third (last) argument was INDENT, which is only a property within KEYWORD-VALUES (KEYWORD-PLIST). Changed to the latter to make the function more flexible.
This is a beginning of a large refactor for the whole `add` operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Creating this PR to make the work visible.