Fix CMake build with Apple Intl (facebook#712)

Summary: Pull Request resolved: facebook#712 Reviewed By: dmitryrykun Differential Revision: D35193801 fbshipit-source-id: 63edc96edc66b3eb4fa01d59ca90994ae8fa4feb
nobodyiam95 · Mar 29, 2022 · 0d2e2dc · 0d2e2dc
1 parent efdd2c1
commit 0d2e2dc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -337,6 +337,12 @@ jobs:
             hermes/utils/build/configure.py
             cmake --build ./build
             cmake --build ./build --target check-hermes
+      - run:
+          name: Build Apple Intl
+          command: |
+            cd "$HERMES_WS_DIR"
+            hermes/utils/build/configure.py --cmake-flags="-DHERMES_ENABLE_INTL=ON" build_intl
+            cmake --build ./build_intl
 
   windows:
     executor:

diff --git a/lib/Platform/Intl/CMakeLists.txt b/lib/Platform/Intl/CMakeLists.txt
@@ -16,6 +16,7 @@ if(HERMES_ENABLE_INTL)
         LINK_LIBS
         ${FOUNDATION}
         hermesBCP47Parser
+        hermesPublic
     )
     # Work around a bug in unity builds where it tries to build Obj-C as C++.
     set_target_properties(hermesPlatformIntl PROPERTIES UNITY_BUILD false)