Skip to content

Commit

Permalink
Simplify test-macos in CircleCI (facebook#765)
Browse files Browse the repository at this point in the history
Summary:
Simplify the test-macos test and bring it in line with our tests on
other platforms. Also switch it to using the XCode build system so that
it uses parallel builds, and we get some additional coverage on a
different build system.

Pull Request resolved: facebook#765

Reviewed By: jpporto

Differential Revision: D37475877

Pulled By: neildhar

fbshipit-source-id: c7dd044270a775ebae7676ffe2cf03a9c4bd2847
  • Loading branch information
neildhar authored and facebook-github-bot committed Jun 28, 2022
1 parent 280a998 commit 85bf7b1
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,32 +283,25 @@ jobs:
- .

test-macos:
# CheckedMalloc.Death fails in release mode, so build a debug version
# TODO: Switch to `release` and reuse `build_macosx` from previous job
<<: *apple_defaults
macos:
xcode: 13.4.1
steps:
- checkout
- checkout:
path: hermes
- run:
name: Install dependencies
command: |
brew install cmake ninja
- run:
name: Set up workspace
command: |
mkdir -p "$HERMES_WS_DIR"
ln -sf "$PWD" "$HERMES_WS_DIR/hermes"
brew install cmake
- run:
name: Run MacOS regression tests in debug mode
command: |
cd "$HERMES_WS_DIR"
cmake -S hermes -B build
cmake -S hermes -B build -GXcode
cmake --build ./build
cmake --build ./build --target check-hermes
- run:
name: Build Apple Intl
command: |
cd "$HERMES_WS_DIR"
cmake -S hermes -B build_intl -DHERMES_ENABLE_INTL=ON
cmake -S hermes -B build_intl -GXcode -DHERMES_ENABLE_INTL=ON
cmake --build ./build_intl
windows:
Expand Down

0 comments on commit 85bf7b1

Please sign in to comment.