Skip to content

Commit

Permalink
Add windows test in CircleCI (facebook#1114)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebook#1114

Reviewed By: avp

Differential Revision: D49014182

Pulled By: neildhar

fbshipit-source-id: 615394848483cb3898980fb65127090462dbba5c
  • Loading branch information
neildhar authored and facebook-github-bot committed Sep 6, 2023
1 parent 440578b commit 91d638f
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
18 changes: 18 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ workflows:
- macos
- emscripten
- test-linux
- test-windows
- test-e2e
- test-e2e-intl
- test-macos-test262
Expand Down Expand Up @@ -314,6 +315,23 @@ jobs:
cmake --build ./build
cmake --build ./build --target check-hermes
test-windows:
executor:
name: win/default
steps:
- checkout:
path: hermes
- run:
name: Set up dependencies
command: |
choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System'
ln -s C:\tools\miniconda3\python C:\tools\miniconda3\python3
- run:
name: Run Hermes regression tests
command: |
cmake -S hermes -B build -G 'Visual Studio 16 2019'
cmake --build build --target check-hermes
windows:
executor:
name: win/default
Expand Down
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Avoid modifying the line endings for lit tests since they change the output.
test/** text eol=lf
2 changes: 1 addition & 1 deletion test/hermes/date-default-timezone.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

// RUN: TZ="MST+7MDT,M3.2.0/2,M11.1.0/2" %hermes -O %s | %FileCheck --match-full-lines %s
// RUN: TZ="MST7MDT" %hermes -O %s | %FileCheck --match-full-lines %s
"use strict";

// Tests are being run under Mountain Time, with DST changes enabled (TZ var).
Expand Down

0 comments on commit 91d638f

Please sign in to comment.