Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortfin LLM Direct-to-batcher tests #987

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
move test file location
  • Loading branch information
renxida committed Feb 21, 2025
commit 889140f8111535d948f7ca8a0885ffe517aa0eab
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,15 @@ async def run(self):


def test_batch_and_nobatch_consistency(server_instance):
"""Test that requests produce identical results regardless of batch size."""
"""
Test that requests produce identical results regardless of batch size.

If this test fails, it means that changing the batch size changes the generation results.

Look for kvcache corruption due to
- improper seq_len / current_position handling in service.py
- improper masking in sharktank
"""
with server_instance.start_service_only() as generate_service:
# Create and run the test process
test_process = BatchConsistencyTestProcess(
Expand Down