Use Intl.DateTimeFormat to fix DST offsets #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeratony
reviewed
Jan 23, 2021
| @@ -31,5 +31,8 @@ | |||
| "eslint": "^5.16.0", | |||
| "mocha": "^6.1.4", | |||
| "nyc": "^14.0.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=8.0.0" | |||
There was a problem hiding this comment.
i think the node version is now 14.0
There was a problem hiding this comment.
That's the current LTS but this package supports all versions before up to v8.
meeratony
approved these changes
Jan 23, 2021
|
@meeratony What's left here? Could it be merged? |
Tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed offsetOf and timeAt to use node's builtin tz database via the Intl.DateTimeFormat api, and added optional date argument to offsetOf, to correctly handle offsets during daylight savings time (Fixes #8)