Skip to content

Commit

Permalink
CSCvu76204: Istio resources clean-up
Browse files Browse the repository at this point in the history
Issue: When aci-cni deployment file is deleted, some of the resources such as istio-operator NS are not deleted.

AciIstioOperator CRD presence in aci-cni deployment drives istio installation which includes
+ istio-operator NS
+ istio-operator deployment
+ istio-system NS
+ istiocontrolplane CR

Fix: This change will set the OwnerReference with AciIstioOperator for all resources that gets created by ACC.

Caveat: There are bunch of istio related CRDs that gets created by upstream istio-operator deployment are not cleaned up even after istio-operator deployment goes away. This is a known issue in upstream community (istio/istio#24038)
  • Loading branch information
kishorejonnala committed Aug 12, 2020
1 parent ad732a6 commit a94364b
Show file tree
Hide file tree
Showing 3 changed files with 722 additions and 31 deletions.
54 changes: 24 additions & 30 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,63 +2,57 @@ go 1.13

require (
github.com/Shopify/sarama v1.26.1
github.com/aws/aws-sdk-go v1.28.2
github.com/aws/aws-sdk-go v1.33.11
github.com/cenk/hub v1.0.1 // indirect
github.com/cenkalti/hub v1.0.1 // indirect
github.com/cenkalti/rpc2 v0.0.0-20200203073230-5ce2854ce0fd // indirect
github.com/containernetworking/cni v0.7.1
github.com/containernetworking/plugins v0.8.5
github.com/coreos/bbolt v1.3.3 // indirect
github.com/coreos/etcd v3.3.13+incompatible
github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf // indirect
github.com/coreos/etcd v3.3.15+incompatible
github.com/coreos/go-systemd/v22 v22.0.0
github.com/davecgh/go-spew v1.1.1
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect
github.com/golang/protobuf v1.3.4
github.com/golang/protobuf v1.4.2
github.com/google/uuid v1.1.1
github.com/gorilla/mux v1.7.0
github.com/gorilla/websocket v1.4.1
github.com/grpc-ecosystem/go-grpc-middleware v1.2.0 // indirect
github.com/gorilla/mux v1.7.4
github.com/gorilla/websocket v1.4.2
github.com/grpc-ecosystem/grpc-gateway v1.14.1 // indirect
github.com/konsorten/go-windows-terminal-sequences v1.0.2 // indirect
github.com/hashicorp/consul v1.3.1 // indirect
github.com/hashicorp/go-msgpack v0.5.5 // indirect
github.com/hashicorp/serf v0.8.5 // indirect
github.com/natefinch/pie v0.0.0-20170715172608-9a0d72014007
github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
github.com/openshift/api v0.0.0-20200521101457-60c476765272
github.com/openshift/api v0.0.0-20200713203337-b2494ecb17dd
github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0
github.com/oxtoacart/bpool v0.0.0-20190530202638-03653db5a59c // indirect
github.com/pkg/errors v0.8.1
github.com/prometheus/client_golang v1.5.0
github.com/prometheus/procfs v0.0.10 // indirect
github.com/pkg/errors v0.9.1
github.com/prometheus/client_golang v1.7.1
github.com/sirupsen/logrus v1.4.2
github.com/socketplane/libovsdb v0.0.0-20170116174820-4de3618546de
github.com/spf13/cobra v0.0.6
github.com/spf13/cobra v1.0.0
github.com/spf13/viper v1.4.0
github.com/stretchr/testify v1.4.0
github.com/stretchr/testify v1.6.1
github.com/tatsushid/go-fastping v0.0.0-20160109021039-d7bb493dee3e
github.com/tmc/grpc-websocket-proxy v0.0.0-20200122045848-3419fae592fc // indirect
github.com/vishvananda/netlink v1.0.0
github.com/yl2chen/cidranger v1.0.0
go.etcd.io/etcd v0.5.0-alpha.5.0.20190911215424-9ed5f76dc03b // indirect
go.uber.org/multierr v1.5.0 // indirect
go.uber.org/zap v1.14.0 // indirect
golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073 // indirect
golang.org/x/lint v0.0.0-20200302205851-738671d3881b // indirect
golang.org/x/net v0.0.0-20200301022130-244492dfa37a
golang.org/x/sys v0.0.0-20200302150141-5c8b2ff67527 // indirect
golang.org/x/time v0.0.0-20191024005414-555d28b269f0
golang.org/x/tools v0.0.0-20200306191617-51e69f71924f // indirect
google.golang.org/genproto v0.0.0-20200306153348-d950eab6f860 // indirect
google.golang.org/grpc v1.27.1
k8s.io/api v0.18.3
k8s.io/apimachinery v0.18.3
k8s.io/client-go v0.18.3
go.etcd.io/etcd v0.5.0-alpha.5.0.20200306183522-221f0cc107cb // indirect
golang.org/x/net v0.0.0-20200707034311-ab3426394381
golang.org/x/time v0.0.0-20200630173020-3af7569d3a1e
google.golang.org/grpc v1.30.0
istio.io/istio v0.0.0-20200811212058-b18b33f83db7
k8s.io/api v0.18.6
k8s.io/apimachinery v0.18.6
k8s.io/client-go v0.18.6
k8s.io/code-generator v0.18.3
k8s.io/kubernetes v1.18.3
sigs.k8s.io/controller-runtime v0.6.0
sigs.k8s.io/controller-runtime v0.6.1
)

replace (
go.etcd.io/bbolt => go.etcd.io/bbolt v1.3.3
google.golang.org/grpc => google.golang.org/grpc v1.26.0
k8s.io/api => k8s.io/api v0.18.3
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.18.3
k8s.io/apimachinery => k8s.io/apimachinery v0.18.3
Expand Down
Loading

0 comments on commit a94364b

Please sign in to comment.