Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: migrate to jakarta.inject as the default api, with shims for bac… #96

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

eledhwen
Copy link
Contributor

@eledhwen eledhwen commented Mar 5, 2024

…k-compat with javax.inject

@eledhwen eledhwen self-assigned this Mar 5, 2024
@eledhwen eledhwen linked an issue Mar 5, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 78.19%. Comparing base (c4a07ed) to head (d50dcfe).

Files Patch % Lines
...a/com/noleme/vault/legacy/VaultLegacyCompiler.java 63.63% 1 Missing and 3 partials ⚠️
src/main/java/com/noleme/vault/Vault.java 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     78.37%   78.19%   -0.19%     
- Complexity      591      596       +5     
============================================
  Files            74       74              
  Lines          1716     1720       +4     
  Branches        256      257       +1     
============================================
  Hits           1345     1345              
- Misses          280      281       +1     
- Partials         91       94       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eledhwen eledhwen merged commit bf832c5 into master Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Handle Jakarta EE @Inject
2 participants