Skip to content

Commit

Permalink
Do not set last_buf flag in subrequests.
Browse files Browse the repository at this point in the history
The last_buf flag should only be set in the last buffer of the main request.
Otherwise, several last_buf flags can appear in output.  This can, for example,
break the chunked filter, which will include several final chunks in output.
  • Loading branch information
arut committed Oct 3, 2016
1 parent 2e12afb commit f3bbd1c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/http/modules/ngx_http_mp4_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,7 @@ ngx_http_mp4_read_mdat_atom(ngx_http_mp4_file_t *mp4, uint64_t atom_data_size)
data = &mp4->mdat_data_buf;
data->file = &mp4->file;
data->in_file = 1;
data->last_buf = 1;
data->last_buf = (mp4->request == mp4->request->main) ? 1 : 0;
data->last_in_chain = 1;
data->file_last = mp4->offset + atom_data_size;

Expand Down
3 changes: 2 additions & 1 deletion src/http/modules/ngx_http_range_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,8 @@ ngx_http_range_singlepart_body(ngx_http_request_t *r,
buf->last -= (size_t) (last - range->end);
}

buf->last_buf = 1;
buf->last_buf = (r == r->main) ? 1 : 0;
buf->last_in_chain = 1;
*ll = cl;
cl->next = NULL;

Expand Down
2 changes: 1 addition & 1 deletion src/http/ngx_http_special_response.c
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ ngx_http_send_refresh(ngx_http_request_t *r)
b->last = ngx_cpymem(p, ngx_http_msie_refresh_tail,
sizeof(ngx_http_msie_refresh_tail) - 1);

b->last_buf = 1;
b->last_buf = (r == r->main) ? 1 : 0;
b->last_in_chain = 1;

out.buf = b;
Expand Down

0 comments on commit f3bbd1c

Please sign in to comment.