crypto: dh - Check mpi_rshift errors

Now that mpi_rshift can return errors, check them. Fixes: 35d2bf2 ("crypto: dh - calculate Q from P for the full public key verification") Signed-off-by: Herbert Xu <[email protected]>
noroot · Aug 17, 2024 · 560efa7 · 560efa7
1 parent 8e3a67f
commit 560efa7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/crypto/dh.c b/crypto/dh.c
@@ -145,9 +145,9 @@ static int dh_is_pubkey_valid(struct dh_ctx *ctx, MPI y)
 	 * ->p is odd, so no need to explicitly subtract one
 	 * from it before shifting to the right.
 	 */
-	mpi_rshift(q, ctx->p, 1);
+	ret = mpi_rshift(q, ctx->p, 1) ?:
+	      mpi_powm(val, y, q, ctx->p);
 
-	ret = mpi_powm(val, y, q, ctx->p);
 	mpi_free(q);
 	if (ret) {
 		mpi_free(val);